-
-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LicensesManager and API/CLI #161
Conversation
Codecov Report
@@ Coverage Diff @@
## master #161 +/- ##
==========================================
+ Coverage 74.61% 77.76% +3.15%
==========================================
Files 21 24 +3
Lines 1670 1907 +237
==========================================
+ Hits 1246 1483 +237
Misses 424 424
Continue to review full report at Codecov.
|
Is this ready for review? |
Thanks for checking in! This side of the house is ready for review. Nothing will happen (and certainly not break) until the |
Updated this to add a |
Thanks a lot for working on this @bollwyvl 🚀 |
A remaining todo on this is to add it to the openapi spec... looking into it. |
Codecov Report
@@ Coverage Diff @@
## master #161 +/- ##
==========================================
+ Coverage 75.69% 78.60% +2.90%
==========================================
Files 24 27 +3
Lines 1757 1996 +239
==========================================
+ Hits 1330 1569 +239
Misses 427 427
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
This adds
lab/api/licenses
and the base class forjupyter lab licenses
(to be refined by a particular application) for listing the licenses of frontend libraries included in the core (and any federated) bundles.The (configurable)
third-party-licenses.json
is collected by@jupyterlab/builder
.This will help ensure that license compliance (for e.g.
Apache-2.0
, which requires distribution of the license text) is not hard to achieve for both core and extension developers.