Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LicensesManager and API/CLI #161

Merged
merged 21 commits into from
Jun 1, 2021
Merged

Conversation

bollwyvl
Copy link
Contributor

@bollwyvl bollwyvl commented Feb 18, 2021

binder-badge

This adds lab/api/licenses and the base class for jupyter lab licenses (to be refined by a particular application) for listing the licenses of frontend libraries included in the core (and any federated) bundles.

The (configurable) third-party-licenses.json is collected by @jupyterlab/builder.

This will help ensure that license compliance (for e.g. Apache-2.0, which requires distribution of the license text) is not hard to achieve for both core and extension developers.

@codecov-io
Copy link

codecov-io commented Feb 20, 2021

Codecov Report

Merging #161 (eea2380) into master (a82794a) will increase coverage by 3.15%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #161      +/-   ##
==========================================
+ Coverage   74.61%   77.76%   +3.15%     
==========================================
  Files          21       24       +3     
  Lines        1670     1907     +237     
==========================================
+ Hits         1246     1483     +237     
  Misses        424      424              
Impacted Files Coverage Δ
jupyterlab_server/__init__.py 87.50% <100.00%> (+1.78%) ⬆️
jupyterlab_server/config.py 63.37% <100.00%> (+0.87%) ⬆️
jupyterlab_server/handlers.py 89.26% <100.00%> (+0.37%) ⬆️
jupyterlab_server/licenses_app.py 100.00% <100.00%> (ø)
jupyterlab_server/licenses_handler.py 100.00% <100.00%> (ø)
jupyterlab_server/tests/test_licenses_api.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a82794a...eea2380. Read the comment docs.

@bollwyvl bollwyvl changed the title [wip] licenses manager, CLI, API licenses manager and API Feb 28, 2021
@bollwyvl bollwyvl changed the title licenses manager and API LicensesManager and API Feb 28, 2021
@bollwyvl bollwyvl changed the title LicensesManager and API LicensesManager and API/CLI Feb 28, 2021
@blink1073
Copy link
Contributor

Is this ready for review?

@bollwyvl
Copy link
Contributor Author

bollwyvl commented Mar 18, 2021

Thanks for checking in!

This side of the house is ready for review. Nothing will happen (and certainly not break) until the @jupyterlab/builder side of the house has been updated, as there won't be any files in place, but it was useful to co-develop the features to smoke test all the bells and whistles.

@bollwyvl
Copy link
Contributor Author

Updated this to add a bundles top-level key to the JSON response, but otherwise, remains ready for review.

@bollwyvl bollwyvl requested a review from goanpeca May 28, 2021 22:08
@goanpeca
Copy link
Member

Thanks a lot for working on this @bollwyvl 🚀

@bollwyvl
Copy link
Contributor Author

A remaining todo on this is to add it to the openapi spec... looking into it.

@codecov-commenter
Copy link

codecov-commenter commented May 29, 2021

Codecov Report

Merging #161 (783e8eb) into master (d1bb603) will increase coverage by 2.91%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #161      +/-   ##
==========================================
+ Coverage   75.69%   78.60%   +2.90%     
==========================================
  Files          24       27       +3     
  Lines        1757     1996     +239     
==========================================
+ Hits         1330     1569     +239     
  Misses        427      427              
Impacted Files Coverage Δ
jupyterlab_server/__init__.py 87.50% <100.00%> (+1.78%) ⬆️
jupyterlab_server/config.py 63.37% <100.00%> (+0.87%) ⬆️
jupyterlab_server/handlers.py 89.26% <100.00%> (+0.37%) ⬆️
jupyterlab_server/licenses_app.py 100.00% <100.00%> (ø)
jupyterlab_server/licenses_handler.py 100.00% <100.00%> (ø)
jupyterlab_server/tests/test_licenses_api.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1bb603...783e8eb. Read the comment docs.

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@blink1073 blink1073 merged commit c348b16 into jupyterlab:master Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move WIP license reporting here from core?
6 participants