Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move WIP license reporting here from core? #160

Closed
bollwyvl opened this issue Feb 15, 2021 · 4 comments · Fixed by #161
Closed

Move WIP license reporting here from core? #160

bollwyvl opened this issue Feb 15, 2021 · 4 comments · Fixed by #161

Comments

@bollwyvl
Copy link
Contributor

Over on jupyterlab/jupyterlab#9779 I've started some work to make frontend library license reporting more structured. The current alpha release includes a third-party-licenses.txt, but the baseline report is pretty simple. That PR moves the reporting to a predictable third-party-license.json structure (even have a schema, but got rid of it) generated by a single codepath in @jupyterlab/builder, and on top of it builds:

  • an API endpoint /lab/api/licenses
  • a CLI tool jupyter lab licenses

...with all the fixin's: different output formats, etc.

Those things would be fine to land there, exclusively, but license compliance seems a thing that is probably even more important to downstream Lab-derived applications. Also, the federated_modules data definitions live over here, which is a pretty important piece.

If this happened, that PR would probably split into:

  • jupyterlab/jupyterlab
    • @jupyterlab/builder dev tool which generates third-party-licenses.json
    • @jupyterlab/licenses-extension which consumes the API
  • jupyterlab/jupyterlab_server
    • the LicensesManager and LicensesHandler
  • not sure
    • the LabLicensesApp for the CLI
      • might be nice to have here for folks to subclass

Any thoughts appreciated!

@afshin
Copy link
Member

afshin commented Feb 17, 2021

Adding the server endpoints seems sound to me, the rest follows 👍

@bollwyvl
Copy link
Contributor Author

Dig. Will get on that this evening.

@bollwyvl
Copy link
Contributor Author

Didn't make it to this (but did get lab 3.0.8 out the door on conda-forge, with some corrected pins and more CLI checks 😪 )

@bollwyvl
Copy link
Contributor Author

Aight, started the PR (#161) and the plumbing to manage the co-development of the features. This is gonna take a sec...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants