-
-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move WIP license reporting here from core? #160
Comments
Adding the server endpoints seems sound to me, the rest follows 👍 |
Dig. Will get on that this evening. |
Didn't make it to this (but did get lab 3.0.8 out the door on conda-forge, with some corrected pins and more CLI checks 😪 ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Over on jupyterlab/jupyterlab#9779 I've started some work to make frontend library license reporting more structured. The current alpha release includes a
third-party-licenses.txt
, but the baseline report is pretty simple. That PR moves the reporting to a predictablethird-party-license.json
structure (even have a schema, but got rid of it) generated by a single codepath in@jupyterlab/builder
, and on top of it builds:/lab/api/licenses
jupyter lab licenses
...with all the fixin's: different output formats, etc.
Those things would be fine to land there, exclusively, but license compliance seems a thing that is probably even more important to downstream Lab-derived applications. Also, the
federated_modules
data definitions live over here, which is a pretty important piece.If this happened, that PR would probably split into:
jupyterlab/jupyterlab
@jupyterlab/builder
dev tool which generatesthird-party-licenses.json
@jupyterlab/licenses-extension
which consumes the APIjupyterlab/jupyterlab_server
LicensesManager
andLicensesHandler
LabLicensesApp
for the CLIAny thoughts appreciated!
The text was updated successfully, but these errors were encountered: