Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to JupyterLab 2.0 #92

Merged
merged 3 commits into from
Apr 21, 2020
Merged

Update to JupyterLab 2.0 #92

merged 3 commits into from
Apr 21, 2020

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Apr 20, 2020

Fixes jupyterlab/jupyterlab#8208

Update to JupyterLab 2.0 and bump a few other widget dependencies.

To test this PR on Binder:

Binder

@blink1073
Copy link
Contributor

Do you mind trying to upgrade miniconda to python 3.7 to fix the appveyor issue?

@jtpio
Copy link
Member Author

jtpio commented Apr 21, 2020

Done, let's see how it goes.

@jtpio
Copy link
Member Author

jtpio commented Apr 21, 2020

Now the error seems to be caused by xeus-cling that can't be installed on Windows.

It looks like this has already been discussed in #81

@blink1073
Copy link
Contributor

I'd say let's drop appveyor.yml, there's no urgent need for the demo to be built on Windows.

@jtpio
Copy link
Member Author

jtpio commented Apr 21, 2020

That sounds reasonable. For reference this was also the case when updating to JupyterLab 1.0: #91

I'll remove appveyor and trigger another Binder build.

@blink1073
Copy link
Contributor

Appveyor failure is expected until we merge this. The Travis failure seemed like a connectivity issue, kicked it.

@blink1073
Copy link
Contributor

Thanks @jtpio!

@blink1073 blink1073 merged commit 268524d into jupyterlab:master Apr 21, 2020
@jtpio jtpio deleted the jlab-2 branch April 21, 2020 19:27
@saulshanabrook
Copy link
Member

@jtpio i think the error is because the version of jupyterlab_server is too old in binder. It needs to be at least 1.1.0: jupyterlab/jupyterlab#8127 and it's 1.0.6.

I am not sure why it's pulling in an old version.

@jtpio
Copy link
Member Author

jtpio commented Apr 22, 2020

This should fix it: conda-forge/jupyterlab-feedstock#213

@jtpio
Copy link
Member Author

jtpio commented Apr 22, 2020

To add more context, the issue mentioned here is this one: jupyterlab/jupyterlab#8231

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MyBinder is Outdated
3 participants