Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to jupyterlab_server >= 1.1.0 #213

Merged
merged 3 commits into from
Apr 24, 2020

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Apr 22, 2020

Align the dependencies with the ones listed in JupyterLab setup.py:

https://github.com/jupyterlab/jupyterlab/blob/2619a79d89f97441d078b98a719da4a9bfccbcb6/setup.py#L139-L144

This should fix: jupyterlab/jupyterlab#8231

Checklist

  • Used a fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Copy link
Contributor

@saulshanabrook saulshanabrook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Yeah this will fix a current issue in binder where it can't load the new extension manager.

@saulshanabrook
Copy link
Contributor

@jtpio I believe we should bump the build number since the version is the same?

@jtpio
Copy link
Member Author

jtpio commented Apr 22, 2020

Ah indeed, good catch!

@saulshanabrook
Copy link
Contributor

@conda-forge-admin, please rerender

@blink1073
Copy link
Member

Thanks!

@blink1073 blink1073 merged commit fe7501d into conda-forge:master Apr 24, 2020
@jtpio jtpio deleted the jupyterlab-server-1-1 branch April 24, 2020 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jupyter Lab V2.1.0 - Extension Manager - Blank Page (Similar issues #7171 & #8122)
4 participants