Make traefik_entrypoint name explicit #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
more informative error if the expected entrypoint doesn't exist, now that we aren't trying to discover it
remove unnecessary dynamic config from tests
so it can be re-used
minrk
changed the title
GeorgianaElena
approved these changes
Mar 17, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This greatly simplifies things, and removes a dynamic step from startup. If folks want to set the entrypoint name when using an external traefik static config, they can tell jupyterhub what to use.
The entrypoint is checked at startup, to make sure dynamic and static config are loaded.
surprising behavior reported in #164 (comment)