Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changelog for 1.0 #176

Merged
merged 5 commits into from
Mar 17, 2023
Merged

changelog for 1.0 #176

merged 5 commits into from
Mar 17, 2023

Conversation

minrk
Copy link
Member

@minrk minrk commented Mar 10, 2023

@GeorgianaElena I think we can make an 0.4.0b1 with this as it is and start asking folks to test it. WDYT?

Copy link
Member

@manics manics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that this repo is back up to date is it worth going for a 1.0.0 prerelease instead?

docs/source/changelog.md Outdated Show resolved Hide resolved
docs/source/changelog.md Outdated Show resolved Hide resolved
docs/source/changelog.md Outdated Show resolved Hide resolved
Co-authored-by: Simon Li <orpheus+devel@gmail.com>
Copy link
Member

@GeorgianaElena GeorgianaElena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm +1 on making a release now.

Now that this repo is back up to date is it worth going for a 1.0.0 prerelease instead?

I also think that a 1.0.0 prerelease makes sense given the latest changes?

@minrk
Copy link
Member Author

minrk commented Mar 13, 2023

is it worth going for a 1.0.0 prerelease instead?

Maybe? I think we're still learning about traefik, so I'd feel slightly more comfortable with 0.4 for now. On the other hand, it's been used in TLJH for ages without apparent issue. WDYT @GeorgianaElena?

I think reasons to maybe consider it not quite ready for 1.0 are:

At the same time, I'm generally for the idea that the bar for 1.0 should be "people use this," which is clearly the case for us already.

@minrk
Copy link
Member Author

minrk commented Mar 13, 2023

Since you're both for 1.0, I updated it to 1.0. I think we're ready for a beta!

@minrk
Copy link
Member Author

minrk commented Mar 13, 2023

FWIW, should we put a deprecation on consul already, as discussed in #155 ?

@minrk minrk changed the title changelog for 0.4 changelog for 1.0 Mar 13, 2023
@GeorgianaElena
Copy link
Member

FWIW, should we put a deprecation on consul already, as discussed in #155 ?

I believe that deprecating it now that we're going for a 1.0 release makes sense.

@manics
Copy link
Member

manics commented Mar 13, 2023

Do you envisage any breaking changes for #170 ? That would be a good reason not to go for 1.0.0.

@minrk
Copy link
Member Author

minrk commented Mar 13, 2023

Do you envisage any breaking changes for #170 ?

I don't think so - it should mainly be rewriting a private method or two that exist now into calling other slightly more generic methods.

I guess it would make the new generic methods reuqired for KV subclasses, but those don't exist outside this package, so I'm not worried about that.

@minrk
Copy link
Member Author

minrk commented Mar 13, 2023

Actually, looking at #170, I think it will probably be a pretty significant reorganization. It shouldn't be public-facing, though.

@minrk
Copy link
Member Author

minrk commented Mar 14, 2023

I went ahead with an implementation of #170 in #185 if folks want to have a look at that before making a release. It has no public-facing changes, purely internal implementation details other than #184 which rolls back an undocumented new feature in favor of simpler explicit config.

# Conflicts:
#	docs/source/changelog.md
@minrk
Copy link
Member Author

minrk commented Mar 17, 2023

OK, updated with the latest PRs. Ready for 1.0b1!

@minrk minrk merged commit 6ec4d5b into jupyterhub:main Mar 17, 2023
@minrk minrk deleted the rel-v2 branch March 17, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants