Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Freeze requirements and setup dependabot #116

Merged
merged 2 commits into from
Feb 19, 2021

Conversation

GeorgianaElena
Copy link
Member

Not sure if I did the setup properly. The steps I followed were:

  • create requirements.ini
  • generate the requirements.txt with pip-compile

From what I understand, setting dependabot's package-ecosystem to pip-compile will enable dependabot to keep both requirments.in and requirements.txt updated whenever it bumps the version of a pkg. But I'm not sure about this as I didn't find any example of a project using this.

@consideRatio, maybe you can advise? <3 ty!

@consideRatio
Copy link
Member

Oh im not sure in general what dependabots logic actually is, still a bit confused! But, this LGTM!

Since requirements.in doesnt contain any constraints, i dont think there would be any change from dependabot, but, confused in general.

I like having a lockfile that can be explicitly updated and inspected with release tags etc though, and now we'll get it :)

@consideRatio
Copy link
Member

Merge merge!?

@GeorgianaElena
Copy link
Member Author

Let's merge 🎉 Do you want to hit the button? :D

@consideRatio consideRatio merged commit fdd36d8 into jupyterhub:master Feb 19, 2021
This was referenced Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants