Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove CircleCi docs builds #118

Closed
GeorgianaElena opened this issue Feb 22, 2021 · 3 comments · Fixed by #121
Closed

Remove CircleCi docs builds #118

GeorgianaElena opened this issue Feb 22, 2021 · 3 comments · Fixed by #121
Labels
enhancement New feature or request

Comments

@GeorgianaElena
Copy link
Member

traefik-proxy still uses CircleCi to build its docs. We should should enable RTD builds instead.
@GeorgianaElena GeorgianaElena added the enhancement New feature or request label Feb 22, 2021
@GeorgianaElena
Copy link
Member Author

@minrk, I believe you are the maintainer for the traefik-proxy rtd project (https://readthedocs.org/projects/jupyterhub-traefik-proxy/). Do you want to add me there too? I would love to enable to enable PR RTD builds and previews for the repo <3

Also, the docs build is currently failing and I want to investigate it :(

@minrk
Copy link
Member

minrk commented Feb 22, 2021

I added you and a few others to RTD. The docs builds are failing due to #116, which I'll open a PR to resolve shortly. Short answer: dependabot is only for applications, not libraries.

@GeorgianaElena
Copy link
Member Author

I added you and a few others to RTD

Thank you @minrk! I also noticed that you also enabled RTD PR builds <3 so I'll open a PR to remove the CircleCI docs build.

@GeorgianaElena GeorgianaElena mentioned this issue Feb 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove CircleCI docs build since now we're using the RTD CI GeorgianaElena/traefik-proxy
2 participants
@minrk @GeorgianaElena