-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin oauthenticator to 0.10.0 for AWS Cognito in the docs #539
Conversation
Assuming tljh has already been installed, we need to make sure the oautheneticator module is at 0.10.0 and if not | ||
do a pip install oauthenticator>=0.10.0 | ||
Assuming tljh has already been installed, we need to make sure the oauthenticator module is at 0.10.0 and if not | ||
do a pip install oauthenticator==0.10.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should also mention that an AWSCongnito authenticator can still be achieved with oauthenticator 0.11, by configuring the GenericOAuthenticator class.
I tried documenting such a configuration in this PR jupyterhub/oauthenticator#336, but I didn't test it however, so it might be incomplete. If it gets accepted, we could later link to the docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Waiting for jupyterhub/oauthenticator#336 to be merged sounds good 👍
Just opened #540 to track this.
What do we do with this now? |
Thinking about this some more, I think the way to do this is to create documentation on using the Generic OAuthenticator, and have subsection for AWS Cognito. What do you think of this direction, @jtpio? |
Sounds good. I won't be able to look into it right now, so converting to a draft in case someone would like to pick it up. |
Action pointFor anyone to make an update to the documentation to reflect that AWS cogito can be configured with a modern enough version of oauthenticator, but that one needs to do it using the GenericOAuthenticator class rather than a dedicated one. |
I'm closing this in favor of #539! |
@consideRatio your comment says this issue is being closed in favor of this issue :D Which issue did you mean? |
I think he meant #729 |
Ah yes I meant #729! I wanted to quickly reduce the amount of PRs listed to ensure other people don't end up investing time to review this PR further! |
As mentioned by @GeorgianaElena in #537 (comment), OAuthenticator 0.11 removed the AWS Cognito authenticator.
This change updates the docs to pin
oauthenticator
to0.10.0
for now.