Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs #336

Merged
merged 7 commits into from
Mar 26, 2020
Merged

Update docs #336

merged 7 commits into from
Mar 26, 2020

Conversation

GeorgianaElena
Copy link
Member

This revamps the docs a bit. I didn't manage to cover everything, but I reordered the sections a bit, added the Jupyter logo and the nice badges from team-compass.

Closes #332

README.md Show resolved Hide resolved
@consideRatio
Copy link
Member

❤️ wooooo excellent work! This has been one of my "oh this really has to get done" mental notes I've had for a while!

README.md Outdated Show resolved Hide resolved
@GeorgianaElena
Copy link
Member Author

GeorgianaElena commented Mar 5, 2020

Thanks for the feedback @consideRatio ❤️. I've just added a new commit that addresses your comments.

@consideRatio
Copy link
Member

Sorry for slow followup @GeorgianaElena, thanks so much for putting in this work! It makes all the difference to have good documentation! ❤️ 🎉 I'm very happy about this PR!!

@consideRatio consideRatio merged commit aec2846 into jupyterhub:master Mar 26, 2020
@GeorgianaElena GeorgianaElena deleted the update_docs branch March 26, 2020 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update repos README.md - links failing etc.
2 participants