-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] preassembly for conda/python #743
[MRG] preassembly for conda/python #743
Conversation
- get_assemble_files() returns list of files needed for assembly - if buildpack.assemble_with_subset is set, only load assemble_files prior to running assembly scripts. Load the rest of the repo afterward conda opts in to this, but currently I think this works for everything *except* requirements.txt
allows assemble_from_subset when requirements.txt doesn't contain any local references
e96622c
to
4f3f192
Compare
This pull request has been mentioned on Jupyter Community Forum. There might be relevant details there: |
I think a |
I bumped the local pip check up one so that it applies to conda as well (adding unittests, too) |
save preassembly of pipenv for a later patch
I decided to save pipenv for the preassembly for another PR, since that should be done by parsing the Pipfile toml, which is added in #748. |
Co-Authored-By: Tim Head <betatim@gmail.com>
Bimbambosch! Nice work. |
[MRG] preassembly for conda/python
re-issue of #410 based on #716
-e .
)pipenv always preassembles (may need local ref check like requirements.txt?)