[WIP] add assemble_subset #410
Conversation
- get_assemble_files() returns list of files needed for assembly - if buildpack.assemble_with_subset is set, only load assemble_files prior to running assembly scripts. Load the rest of the repo afterward conda opts in to this, but currently I think this works for everything *except* requirements.txt
minrk
force-pushed
the
conda-env-first-again
branch
from
c16e995
to
7291c29
Compare
R and Docker can't assemble from the subset because they can refer to local files. Julia can, though.
allows assemble_from_subset when requirements.txt doesn't contain any local references
|
Can a What do you think of a build pack being able to have assemble files that are run before copying over the repo and after? This way a build pack could support this but lets it opt out sometimes? Too complex/convoluted? |
| @@ -93,10 +93,15 @@ | |||
| {{sd}} | |||
| {% endfor %} | |||
|
|
|||
| # Copy and chown stuff. This doubles the size of the repo, because | |||
| # you can't actually copy as USER, only as root! Thanks, Docker! | |||
| # FIXME: use COPY --chown with docker 17.09 to avoid copy+chown in two steps | |||
| @@ -12,6 +12,10 @@ class JuliaBuildPack(CondaBuildPack): | |||
| See https://github.com/JuliaPy/PyCall.jl/issues/410 | |||
|
|
|||
| """ | |||
|
|
|||
| # REQUIRE can't refer to local files, can it? | |||
| assemble_from_subset = True | |||
There was a problem hiding this comment.
Worth checking with #393 and the new way of specifying dependencies in Julia.
There was a problem hiding this comment.
Good catch! I think it will affect Julia with the project stuff.
You can see an example of this in PythonBuildPack, where |
|
Closing in favor of #743 |
Marked WIP for discussion. I though I opened this ages ago, but apparently forgot.
This improves the use of build caching by separating 'assemble' into two steps:
This enables re-using the build cache from one build to the next, greatly expediting rebuilds in cases where the environment spec doesn't change.
Changes:
prior to running assembly scripts. Load the rest of the repo afterward
conda opts in to this, but currently I think this works for everything except requirements.txt. And requirements.txt could as well, as long as we peek in the contents to look for local
-e .references.