Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds translator to the NotebookShell #6725

Merged
merged 3 commits into from
Feb 10, 2023

Conversation

brichet
Copy link
Contributor

@brichet brichet commented Feb 9, 2023

This adds a translator to the NotebookShell, and translates the title of the side panels button.

Fixes #6722

Related discussion at #6719 (comment)

@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2023

Binder 👈 Launch a Binder on branch brichet/notebook/localize_notebook_shell

@jtpio jtpio added this to the 7.0 milestone Feb 9, 2023
import { ITranslator } from '@jupyterlab/translation';
import { INotebookShell } from '@jupyter-notebook/application';

const translator: JupyterFrontEndPlugin<void> = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if we need to create a new package for this plugin.

Or maybe we put the plugin in application-extension directly to keep things simpler: https://github.com/jupyter/notebook/blob/main/packages/application-extension/src/index.ts

Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio jtpio merged commit cc39a28 into jupyter:main Feb 10, 2023
@brichet brichet deleted the localize_notebook_shell branch February 10, 2023 13:54
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Localize the Notebook shell
2 participants