Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Localize the Notebook shell #6722

Closed
jtpio opened this issue Feb 9, 2023 · 0 comments · Fixed by #6725
Closed

Localize the Notebook shell #6722

jtpio opened this issue Feb 9, 2023 · 0 comments · Fixed by #6725
Labels
enhancement
Milestone
7.0

Comments

@jtpio
Copy link
Member

jtpio commented Feb 9, 2023

As a follow-up to #6719, we should consider localizing the notebook shell since some strings are now user-facing:

notebook/packages/application/src/panelhandler.ts

Line 93 in 905553e

closeButton.title = 'Collapse side panel';

@jtpio jtpio added this to the 7.0 milestone Feb 9, 2023
@jupyterlab-probot jupyterlab-probot bot added the status:Needs Triage Applied to issues that need triage label Feb 9, 2023
@jtpio jtpio mentioned this issue Feb 9, 2023
Merged
@jtpio jtpio removed the status:Needs Triage Applied to issues that need triage label Feb 9, 2023
@brichet brichet mentioned this issue Feb 9, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
7.0
Development

Successfully merging a pull request may close this issue.

Adds translator to the NotebookShell brichet/notebook
1 participant
@jtpio