Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add help page to docs and update README #1377

Merged
merged 4 commits into from
Sep 12, 2020
Merged

add help page to docs and update README #1377

merged 4 commits into from
Sep 12, 2020

Conversation

willingc
Copy link
Member

@willingc willingc commented Sep 12, 2020 •
edited
Loading

Closes #1376

@willingc willingc mentioned this pull request Sep 12, 2020
Closed
@willingc
Copy link
Member Author

Thanks @t-makaro for the review. Once it is green, I will merge. Hope you are doing well.

choldgraf
choldgraf approved these changes Sep 12, 2020
View reviewed changes
Copy link
Contributor

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨✨🚀🚀

@willingc willingc merged commit 3c9a67a into jupyter:master Sep 12, 2020
@willingc
Copy link
Member Author

Thanks @choldgraf. I'm thinking that it would be good to move this over to the newer doc style thta we have been using.

@willingc willingc deleted the clarify-help branch September 12, 2020 18:49
@choldgraf
Copy link
Contributor

Do you mean MyST? +1 from me obviously :-)

@willingc
Copy link
Member Author

@cholgraf Will you open an issue asking folks if there is any technical reason not to do so.

@choldgraf
Copy link
Contributor

#1378

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@choldgraf choldgraf choldgraf approved these changes

@t-makaro t-makaro t-makaro approved these changes

@MSeal MSeal Awaiting requested review from MSeal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GitHub Issues not mentioned on website
3 participants
@willingc @choldgraf @t-makaro