-
Notifications
You must be signed in to change notification settings - Fork 567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix ansi2latex filtering #1077
fix ansi2latex filtering #1077
Conversation
FWIW, I've solved this problem in I assume this would still need #1073 (which is a good idea anyway). I think there is no perfect solution though, because the Jupyter notebook format has some inconsistencies regarding trailing |
The results here look much nicer than mine in #1073, but I feel like trimming all trailing |
Alright, I adjusted to just remove that whitespace. I agree this is a cleaner solution, and it does appear to render as expected with my test pdfs. Right now this technically removes trailing |
@t-makaro When you think about it, it doesn't really make sense to add this functionality to a function named
Yes, this sounds more reasonable. This will not change the result, but I think in the long run it is better to have functions that do what their name suggests and not arbitrary other things on top of that. |
Now implemented using a filter called: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me @t-makaro. I'll leave it up to you which PR to go with. Though sentiment seems that this one is preferred.
This pull request has been mentioned on Jupyter Community Forum. There might be relevant details there: https://discourse.jupyter.org/t/nbconvert-5-6-0-release/1867/1 |
Alternative to #1073. Fixes #1071
This produces:
As opposed to what #1073 produces:
@MSeal I'll leave it to you to decide which option to choose.