Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for line break breaking verbatim environment in style_jupyter.tplx #1073

Closed
wants to merge 1 commit into from

Conversation

njapke
Copy link

@njapke njapke commented Jul 30, 2019

This should fix #1071 though I have not yet tested it extensively.

@t-makaro t-makaro self-requested a review July 30, 2019 01:25
@t-makaro
Copy link
Contributor

Due to styling issues, I think I prefer #1077 since it fixes an underlying issue with how the ansi2latex filter behaves (it should not be placing the final newline in the command since that newline is only there in the stored ipynb file not the actual coded string in the notebook).

@t-makaro t-makaro requested review from MSeal and removed request for t-makaro July 31, 2019 01:49
@t-makaro t-makaro added this to the 5.6 milestone Jul 31, 2019
@mgeier
Copy link
Contributor

mgeier commented Jul 31, 2019

It makes sense to make this change, but it is not the full solution, see #1077 (comment).

@t-makaro
Copy link
Contributor

t-makaro commented Aug 1, 2019

Thank you @njapke for the contribution! Your input helped in making #1077. Closing in favour of #1077.

@t-makaro t-makaro closed this Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Colored Text Crashes PDF Export
3 participants