Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve restarter logic #717

Merged
merged 6 commits into from
Nov 22, 2021
Merged

Commits on Nov 1, 2021

  1. Add tests for restarter

    One simple test for recovery after a single "crash" + one test of handling "infinitely" crashing kernels, i.e. that the restart limit is respected.
    vidartf committed Nov 1, 2021
    Configuration menu
    Copy the full SHA
    6c803a7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6889cea View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2021

  1. Use heuristic to identify "stable" startup of kernel

    This is mainly due to the weakness of the previous method: `is_alive` only tests that the kernel process is alive, it does not indicate that the kernel has successfully completed startup. To solve this correctly, we would need to wait for a kernel info reply, but it is not necessarily appropriate to start a kernel client + channels in the restarter. Therefore, we use a "has been alive continuously for X time" as a heuristic for a stable start up.
    vidartf committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    03f3fad View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7ed3379 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    28e62b9 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2021

  1. Fix some broken logic

    vidartf committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    89fee5e View commit details
    Browse the repository at this point in the history