Improve restarter logic #717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One simple test for recovery after a single "crash" + one test of handling "infinitely" crashing kernels, i.e. that the restart limit is respected.
kevin-bates
reviewed
Nov 2, 2021
This is mainly due to the weakness of the previous method: `is_alive` only tests that the kernel process is alive, it does not indicate that the kernel has successfully completed startup. To solve this correctly, we would need to wait for a kernel info reply, but it is not necessarily appropriate to start a kernel client + channels in the restarter. Therefore, we use a "has been alive continuously for X time" as a heuristic for a stable start up.
vidartf
force-pushed
the
fix-async-restarter
branch
from
cba77a0
to
7ed3379
Compare
|
The ubuntu 3.6 test was hung up (after 5 hours) so I cancelled and restarted the workflow. |
kevin-bates
approved these changes
Nov 4, 2021
There was a problem hiding this comment.
LGTM - thank you @vidartf. I think the test intermittencies are unrelated.
davidbrochart
approved these changes
Nov 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #715.
There is a small change in the behavior of
KernelRestarter.poll()and the async variant that should be considered whether it is appropriate (or if a better alternative exists). I.e. 2fabf92 . The other parts should be uncontroversial.