Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove jupyter_notebook_config.py #1945

Merged

Conversation

mathbunnyru
Copy link
Member

Describe your changes

Issue ticket if applicable

Checklist (especially for first-time contributors)

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests
  • I will try not to use force-push to make the review process easier for reviewers
  • I have updated the documentation for significant changes

@mathbunnyru
Copy link
Member Author

@jtpio if that's ok I would like to ask you to take a look here as well.

After this change is merged, I will also try to update the documentation, where some options are passed (many examples use NotebookApp and give warnings currently) and I will tag you as well.

@jtpio
Copy link
Member

jtpio commented Jul 26, 2023

Looks good thanks @mathbunnyru.

Notebook 7 should indeed be able to pick up jupyter_server_config.py.

@mathbunnyru mathbunnyru merged commit aedf3e7 into jupyter:main Jul 26, 2023
kentwait pushed a commit to kentwait/docker-stacks that referenced this pull request Aug 3, 2023
* Remove jupyter_notebook_config.py

* Update Dockerfile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants