Skip to content

Commit

Permalink
Remove jupyter_notebook_config.py (#1945)
Browse files Browse the repository at this point in the history
* Remove jupyter_notebook_config.py

* Update Dockerfile
  • Loading branch information
mathbunnyru authored Jul 26, 2023
1 parent df6884f commit aedf3e7
Showing 1 changed file with 1 addition and 6 deletions.
7 changes: 1 addition & 6 deletions base-notebook/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -56,16 +56,11 @@ CMD ["start-notebook.sh"]

# Copy local files as late as possible to avoid cache busting
COPY start-notebook.sh start-singleuser.sh /usr/local/bin/
# Currently need to have both jupyter_notebook_config and jupyter_server_config to support classic and lab
COPY jupyter_server_config.py docker_healthcheck.py /etc/jupyter/

# Fix permissions on /etc/jupyter as root
USER root

# Legacy for Jupyter Notebook Server, see: [#1205](https://github.com/jupyter/docker-stacks/issues/1205)
RUN sed -re "s/c.ServerApp/c.NotebookApp/g" \
/etc/jupyter/jupyter_server_config.py > /etc/jupyter/jupyter_notebook_config.py && \
fix-permissions /etc/jupyter/
RUN fix-permissions /etc/jupyter/

# HEALTHCHECK documentation: https://docs.docker.com/engine/reference/builder/#healthcheck
# This healtcheck works well for `lab`, `notebook`, `nbclassic`, `server` and `retro` jupyter commands
Expand Down

0 comments on commit aedf3e7

Please sign in to comment.