Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable default_url in ExtensionApp #393

Merged
merged 1 commit into from
Jan 21, 2021
Merged

Re-enable default_url in ExtensionApp #393

merged 1 commit into from
Jan 21, 2021

Conversation

afshin
Copy link
Contributor

@afshin afshin commented Jan 21, 2021

This addresses issues we're seeing in JupyterLab, e.g. jupyterlab/jupyterlab#8959

ExtensionApp was missing a configurable default_url trait.

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit 2477da6 into jupyter-server:master Jan 21, 2021
Zsailer added a commit to Zsailer/jupyter_server that referenced this pull request Nov 18, 2022
* use file name for secret_file

* Bump to 0.20.3
hMED22 pushed a commit to hMED22/jupyter_server that referenced this pull request Jan 23, 2023
Re-enable default_url in ExtensionApp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants