Skip to content

Commit

Permalink
Merge pull request #393 from afshin/default-url
Browse files Browse the repository at this point in the history
Re-enable default_url in ExtensionApp
  • Loading branch information
blink1073 authored Jan 21, 2021
2 parents edf4a08 + 028feb0 commit 2477da6
Showing 1 changed file with 9 additions and 1 deletion.
10 changes: 9 additions & 1 deletion jupyter_server/extension/application.py
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,12 @@ def get_extension_point(cls):
# Extension URL sets the default landing page for this extension.
extension_url = "/"

default_url = Unicode().tag(config=True)

@default('default_url')
def _default_url(self):
return self.extension_url

# Extension can configure the ServerApp from the command-line
classes = [
ServerApp,
Expand Down Expand Up @@ -332,7 +338,6 @@ def _jupyter_server_config(cls):
base_config = {
"ServerApp": {
"jpserver_extensions": {cls.get_extension_package(): True},
"default_url": cls.extension_url
}
}
base_config["ServerApp"].update(cls.serverapp_config)
Expand Down Expand Up @@ -438,6 +443,9 @@ def _load_jupyter_server_extension(cls, serverapp):
if cls._is_starter_app:
serverapp._starter_app = extension
extension.initialize()
# Set the serverapp's default url to the extension's url.
if cls._is_starter_app:
serverapp.default_url = extension.default_url
return extension

@classmethod
Expand Down

0 comments on commit 2477da6

Please sign in to comment.