Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ExternalResource: the test failure was lost.. #1335

Closed
wants to merge 2 commits into from
Closed

Fix ExternalResource: the test failure was lost.. #1335

wants to merge 2 commits into from

Commits on Jun 28, 2016

  1. Fix ExternalResource: the test failure was lost.. 

    .. when the test failed *and* closing the resource failed:
only the exception coming from the after() method was propagated,
as per semantics of the try-finally
(see http://docs.oracle.com/javase/specs/jls/se8/html/jls-14.html#jls-14.20.2).

Finally, the new behavior is compatible with @after method semantics
(see class RunAfters).

Fixes junit-team#1334, point 1.
    @alb-i986
    alb-i986 committed Jun 28, 2016
    Configuration menu
    Copy the full SHA
    586bd1d View commit details
    Browse the repository at this point in the history

  2. rm unused import

    @alb-i986
    alb-i986 committed Jun 28, 2016
    Configuration menu
    Copy the full SHA
    ddda99c View commit details
    Browse the repository at this point in the history