Fix ExternalResource: the test failure was lost.. #1335
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.. when the test failed *and* closing the resource failed: only the exception coming from the after() method was propagated, as per semantics of the try-finally (see http://docs.oracle.com/javase/specs/jls/se8/html/jls-14.html#jls-14.20.2). Finally, the new behavior is compatible with @after method semantics (see class RunAfters). Fixes junit-team#1334, point 1.
|
I don't like the duplication with @junit-team/junit-committers Please take a look! |
| try { | ||
| base.evaluate(); | ||
| } catch(Throwable t) { |
There was a problem hiding this comment.
Style-nit : please put a space after "catch" (we use Google Java style which requires spaces around keywords like "if" and "catch"
|
LGTM other than very minor style issues |
| after(); | ||
| try { | ||
| after(); | ||
| } catch(Throwable t) { |
|
I fixed the style issues and merged it. Thanks! @alb-i986 would you please update the release notes? |
@kcooney Done. Sorry for the delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.. when the test failed and closing the resource failed:
only the exception coming from the after() method was propagated, as per semantics of the try-finally
(see http://docs.oracle.com/javase/specs/jls/se8/html/jls-14.html#jls-14.20.2).
Finally, the new behavior is compatible with
@Aftermethod semantics (see class RunAfters).Fixes #1334, point 1.