Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ReleaseMachines method to the Controller. #17

Merged
merged 3 commits into from
Apr 3, 2016

Conversation

howbazaar
Copy link
Contributor

Based on unlanded PR #15

if err != nil {
// A 409 Status code is "No Matching Machines"
if svrErr, ok := errors.Cause(err).(ServerError); ok {
if svrErr.StatusCode == http.StatusBadRequest {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using switch here would be nicer

@mjs
Copy link

mjs commented Apr 3, 2016

LGTM

@howbazaar
Copy link
Contributor Author

$$merge$$

@jujubot
Copy link
Contributor

jujubot commented Apr 3, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju-gomaasapi

@jujubot jujubot merged commit f18e7c2 into juju:master Apr 3, 2016
@howbazaar howbazaar deleted the release-machines branch April 3, 2016 22:35
jujubot added a commit that referenced this pull request Apr 4, 2016
Add the method to start machines

Based on PRs #16 and #17.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants