Controller.AllocateMachine #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 2, 2016
Merged
| @@ -36,7 +37,7 @@ func (*bootResourceSuite) TestReadBootResources(c *gc.C) { | |||
|
|
|||
| func (*bootResourceSuite) TestLowVersion(c *gc.C) { | |||
| _, err := readBootResources(version.MustParse("1.9.0"), parseJSON(c, bootResourcesResponse)) | |||
| c.Assert(err.Error(), gc.Equals, `no boot resource read func for version 1.9.0`) | |||
| c.Assert(err, jc.Satisfies, IsUnsupportedVersionError) | |||
There was a problem hiding this comment.
Keeping it as the error text is good to be human readable and understandable.
|
Lots of great stuff. LGTM. |
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju-gomaasapi |
jujubot
added a commit
that referenced
this pull request
Apr 3, 2016
Filter machines Based on unlanded PR #15
jujubot
added a commit
that referenced
this pull request
Apr 3, 2016
Add ReleaseMachines method to the Controller. Based on unlanded PR #15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch adds the first of the POST methods, AllocateMachine. This meant there was a bit of churn around the testing http server to handle posts as well as gets, and to read the post form.
I also added a bunch of error types. I'd like all errors returned out of the new interfaces to be one of those errors. I have started by updating the machine and boot-resources parsing methods, but the others can be done as I touch the files again.
Added a helper method to get the ServerError, as it was being used in a bunch of tests.
Updated client_test.go to import gocheck with the "gc" name.
The post API call has been tested interactively with my test maas program. Yay dry run.
Go vet was complaining about Id saying it should be ID, and Cpu to be CPU, so I've updated those.
Also added a helper type to add url values only if they were non-zero.