Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make cli mode respect log.level #2124

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

kradalby
Copy link
Collaborator

@kradalby kradalby commented Sep 11, 2024

Fixes #2119

Summary by CodeRabbit

  • New Features

    • Enhanced logging configuration capabilities for the CLI client, allowing for more granular control over log levels.
  • Bug Fixes

    • Improved integration of structured logging setup in the configuration process.

Fixes juanfont#2119

Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
@kradalby kradalby requested a review from juanfont as a code owner September 11, 2024 07:25
Copy link
Contributor

coderabbitai bot commented Sep 11, 2024

Walkthrough

The pull request modifies the LoadCLIConfig function in the hscontrol/types/config.go file by introducing a new logging configuration. A local variable logConfig is created to manage log levels, which are then applied to the global logging settings. The Log field in the Config struct is updated to include this new logging configuration, enhancing the logging capabilities of the CLI client.

Changes

Files Change Summary
hscontrol/types/config.go Added logConfig variable to manage logging levels and updated Log field in Config struct.

Assessment against linked issues

Objective Addressed Explanation
Only print debug/trace when specified in the configuration (#2119)

🐰 In the meadow, logs now play,
With levels set, they won't betray.
Configs whisper, soft and bright,
Debugs and traces in their right.
Hoppy changes, clear and neat,
A joyful log, a rabbit's treat! 🌼


Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 7be8796 and f077143.

Files selected for processing (1)
  • hscontrol/types/config.go (2 hunks)
Additional comments not posted (1)
hscontrol/types/config.go (1)

735-736: LGTM!

The changes to the LoadCLIConfig function look good:

  • The log configuration is loaded using the logConfig() function.
  • The global logging level is set based on the loaded configuration.
  • The loaded log configuration is included in the returned Config struct.

These enhancements improve the logging setup for the CLI client.

Also applies to: 747-747


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@kradalby kradalby enabled auto-merge (squash) September 11, 2024 07:26
@kradalby kradalby merged commit 4b02dc9 into juanfont:main Sep 11, 2024
117 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] headscale nodes list always prints debug/trace messages
2 participants