Add jsx-tag-spacing rule (Fixes #693) #707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @param {ASTNode} node - The JSX element node. | ||
| * @returns {Token} The token before the closing bracket. | ||
| */ | ||
| function getTokenBeforeClosingBracket(node) { |
There was a problem hiding this comment.
This function (and validateBeforeSelfClosing) were basically copied from jsx-space-before-closing.
|
This LGTM! @yannickcr, with this we could deprecate |
Jessidhia
force-pushed
the
jsx-tag-spacing
branch
from
a1e0011
to
29a5376
Compare
|
|
||
| The following patterns are considered warnings when configured `"never"`: | ||
|
|
||
| ```js |
There was a problem hiding this comment.
It would be great if these used jsx instead of js for better syntax highlighting.
There was a problem hiding this comment.
didn't know GFM supported that :o
|
LGTM. Thanks @Kovensky! |
Jessidhia
force-pushed
the
jsx-tag-spacing
branch
from
2e0207a
to
7028de0
Compare
|
Rebased to fix the merge conflict. |
Jessidhia
force-pushed
the
jsx-tag-spacing
branch
from
18c9664
to
1a2c886
Compare
|
hi. any movement on this? looking forward to it |
|
@Kovensky this needs to be freshly rebased. @yannickcr, could you review after that and merge if i's OK? |
ljharb
approved these changes
Oct 23, 2016
Jessidhia
force-pushed
the
jsx-tag-spacing
branch
from
1a2c886
to
3494587
Compare
|
@ljharb @yannickcr done! The only conflict was in |
ljharb
approved these changes
Oct 24, 2016
Jessidhia
force-pushed
the
jsx-tag-spacing
branch
from
3494587
to
1289239
Compare
|
Rebased to fix merge conflicts again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #706 after some discussion summarised on #693 (comment).