Add jsx-closing-bracket-atomic rule (Fixes #693) #706
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // Constants | ||
| // ------------------------------------------------------------------------------ | ||
|
|
||
| var MESSAGE = 'JSX tag closing has embedded whitespace'; |
There was a problem hiding this comment.
How about
Self-closing JSX elements must not have whitespace between the `/` and the `>`
and
JSX closing tags must not have whitespace between the `<`, the `/`, and the tag name.
?
There was a problem hiding this comment.
I don't check the position of the tag name here, only for the presence of /> and </.
Thinking about it, checking for the tag name sounds like a job for a possible "jsx-space-after-opening" rule...
There was a problem hiding this comment.
In this case it'd be jsx-no-space-in-closing tho.
There was a problem hiding this comment.
Hm... conceptually, at least in my head, a rule that checks for </ foo> should also check for < foo> and < foo/>.
There was a problem hiding this comment.
yeah, that's true. perhaps making this rule handle all of those would be helpful?
|
Closed in favour of #707. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minimal working implementation. This is probably missing things :)
I also don't really like the error message, but I couldn't think of a better one.