Fix jsx-curly-spacing: spacing around spread operator #610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var first = context.getFirstToken(node); | ||
| var last = sourceCode.getLastToken(node); | ||
| var second = context.getTokenAfter(first); | ||
| var penultimate = sourceCode.getTokenBefore(last); |
There was a problem hiding this comment.
just put these declarations inside the function to reduce copy pasting
| code: '<App foo={bar/* comment */} {...baz/* comment */} />;', | ||
| options: ['never'], | ||
| parserOptions: parserOptions, | ||
| parser: 'babel-eslint' |
There was a problem hiding this comment.
why do you need the babel-eslint parser for jsx object spread? that should only be needed for JS object spread.
There was a problem hiding this comment.
ah, sorry, just copy pasted and modified this case https://github.com/yannickcr/eslint-plugin-react/blob/master/tests/lib/rules/jsx-curly-spacing.js#L81-L86
There was a problem hiding this comment.
hm, i wouldn't expect that one to need it either
There was a problem hiding this comment.
this test case was added in #584, and it seems that the issue wasn't related to babel-eslint parser, so I think it is safe to remove them both
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #606
Added two type of tests: