jsx-curly-spacing rule breaks with comments

[jkimbo]

When the jsx-curly-spacing rule is set to never the rule reports an error when there is a comment in the expression. I've added a failing test to illustrate this but I'm not sure how to go about fixing it. Any pointers?

Using https://astexplorer.net/#/Y9uxLiaZ7W it looks like it should be possible to use the trailingComments and leadingComments attributes on the node to take comments into account when comparing ranges though I'm not sure how to access them in the isSpaced function (https://github.com/jkimbo/eslint-plugin-react/blob/2b5a612755723862ec51790b7a6037d3ed68e594/lib/rules/jsx-curly-spacing.js#L37-L45)

[yannickcr]

Thanks for the failing test case, it really helps to figure out the problem.

For the fix, I think I will replace isSpaced by the new ESLint isSpaceBetweenTokens function that already ignore comments.

[jkimbo]

Sounds like a good solution. Thanks!