Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backports for 5.2.3 #453

Merged
merged 1 commit into from
Oct 4, 2017
Merged

Backports for 5.2.3 #453

merged 1 commit into from
Oct 4, 2017

Conversation

erayd
Copy link
Contributor

@erayd erayd commented Oct 4, 2017

Bugfixes from 6.0.0 that can be backported to 5.2.3 without breaking backwards-compatibility.

Backported PRs

Skipped PRs

There are no skipped PRs.

@erayd
[BUGFIX] Don't resolve a schema id against itself (jsonrainbow#452)
dfbcc82 
* Don't resolve a schema id against itself

* Add test for double-resolve bugfix
bighappyface
bighappyface approved these changes Oct 4, 2017
View reviewed changes
Copy link
Collaborator

@bighappyface bighappyface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for dfbcc82

@bighappyface bighappyface merged commit 7ccb0e6 into jsonrainbow:5.x.x Oct 4, 2017
@bighappyface
Copy link
Collaborator

https://github.com/justinrainbow/json-schema/releases/tag/5.2.3

@erayd
Copy link
Contributor Author

erayd commented Oct 4, 2017

@bighappyface Thanks 🥇 .

@erayd erayd deleted the backport-523 branch October 4, 2017 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bighappyface bighappyface bighappyface approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erayd @bighappyface