[BUGFIX] Don't resolve a schema id against itself #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Probably a good idea to add a test for this. |
|
LGTM |
I agree. Done :-). |
erayd
added a commit
to erayd/json-schema
that referenced
this pull request
Oct 4, 2017
* Don't resolve a schema id against itself * Add test for double-resolve bugfix
Merged
bighappyface
pushed a commit
that referenced
this pull request
Oct 4, 2017
dkarlovi
referenced
this pull request
in dkarlovi/json-schema-behat-external-ref
Oct 5, 2017
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add a missing condition to prevent resolving a schema id against itself. This prevents potential double-resolution of relative paths.
Why
Because this is a bug, and double-resolution of relative paths results in an incorrect dereferencing result.