Test early placement of unevaluatedItems|Properties with $ref #706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Instead of reordering existing tests, should we create separate tests to cover specifically this issue? If someone else has had problems with the current ordering, you're removing their sanity tests. |
|
Fair point. I'm happy to redo as separate tests. |
marksparkza
force-pushed
the
unevaluated-before-ref
branch
from
84ef2c2 to
4a2c61e
Compare
|
Is there anything this PR was waiting on that made it not be merged? I'm going to assume "no" and merge it given it's been sitting here and has multiple approvals. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows on from 8ba1c90, which produced test failures in my implementation. I had the same problem with the changes in this PR, which puts
unevaluated*before$ref.