Update unevaluted with dynamic ref to be more likely to catch errors

json-schema-org · Oct 27, 2023 · 8ba1c90 · 8ba1c90
1 parent 2834c63
commit 8ba1c90
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 6 deletions.
diff --git a/tests/draft2019-09/unevaluatedItems.json b/tests/draft2019-09/unevaluatedItems.json
@@ -504,8 +504,9 @@
                     "items": [
                         { "type": "number" },
                         {
-                            "$recursiveRef": "#",
-                            "unevaluatedItems": false
+                            "$comment": "unevaluatedItems comes first so it's more likely to catch bugs with implementations that are sensitive to keyword ordering",
+                            "unevaluatedItems": false,
+                            "$recursiveRef": "#"
                         }
                     ]
                 }

diff --git a/tests/draft2019-09/unevaluatedProperties.json b/tests/draft2019-09/unevaluatedProperties.json
@@ -737,8 +737,9 @@
                     "properties": {
                         "node": true,
                         "branches": {
-                            "$recursiveRef": "#",
-                            "unevaluatedProperties": false
+                            "$comment": "unevaluatedProperties comes first so it's more likely to bugs errors with implementations that are sensitive to keyword ordering",
+                            "unevaluatedProperties": false,
+                            "$recursiveRef": "#"
                         }
                     },
                     "required": ["node"]

diff --git a/tests/draft2020-12/unevaluatedItems.json b/tests/draft2020-12/unevaluatedItems.json
@@ -480,12 +480,13 @@
                 "baseSchema": {
                     "$id": "/baseSchema",
 
+                    "$comment": "unevaluatedItems comes first so it's more likely to catch bugs with implementations that are sensitive to keyword ordering",
+                    "unevaluatedItems": false,
                     "type": "array",
                     "prefixItems": [
                         { "type": "string" }
                     ],
                     "$dynamicRef": "#addons",
-                    "unevaluatedItems": false,
 
                     "$defs": {
                         "defaultAddons": {

diff --git a/tests/draft2020-12/unevaluatedProperties.json b/tests/draft2020-12/unevaluatedProperties.json
@@ -733,12 +733,13 @@
                 "baseSchema": {
                     "$id": "/baseSchema",
 
+                    "$comment": "unevaluatedProperties comes first so it's more likely to catch bugs with implementations that are sensitive to keyword ordering",
+                    "unevaluatedProperties": false,
                     "type": "object",
                     "properties": {
                         "foo": { "type": "string" }
                     },
                     "$dynamicRef": "#addons",
-                    "unevaluatedProperties": false,
 
                     "$defs": {
                         "defaultAddons": {