This repository has been archived by the owner on Mar 23, 2024. It is now read-only.
Improve spaces inside array brackets rules #896
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markelog
force-pushed
the
SpacesInsideArrayBrackets
branch
from
572fae9
to
53c76e6
Compare
Same as with #893 (comment) |
| @@ -24,7 +24,7 @@ | |||
| "requireBlocksOnNewline": 1, | |||
| "disallowEmptyBlocks": true, | |||
| "requireSpacesInsideObjectBrackets": "all", | |||
| "requireSpacesInsideArrayBrackets": "all", | |||
| "disallowSpacesInsideArrayBrackets": "all", | |||
There was a problem hiding this comment.
/cc @jdlrobson, @jdforrester, @Krinkle
Is that OK?
|
Wow, it would also fix #111 |
Aside from main improvement: * Simplify logic check * Use assertion API * Add couple more tests for main logic * Fix accessor array case i.e. as expression statement Fixes jscs-dev#111 Ref jscs-dev#721 Ref jscs-dev#429
markelog
force-pushed
the
SpacesInsideArrayBrackets
branch
from
53c76e6
to
85a7f29
Compare
Aside from main improvement: * Simplify logic check * Use assertion API * Add couple more tests for main logic * Fix accessor array case i.e. as expression statement Fixes jscs-dev#721 Fixes jscs-dev#429
Since previous commits fixed some of the array bracket case, jscs now finds more inconsistancies, yey! And it found some in this code-base too
markelog
force-pushed
the
SpacesInsideArrayBrackets
branch
from
85a7f29
to
462b9e3
Compare
markelog
added a commit
to markelog/node-jscs
that referenced
this pull request
Jan 15, 2015
Since previous commits fixed some of the array bracket case, jscs now finds more inconsistancies, yey! And it found some in this code-base too Closes jscs-devgh-896
markelog
added a commit
that referenced
this pull request
Jan 15, 2015
Since previous commits fixed some of the array bracket case, jscs now finds more inconsistancies, yey! And it found some in this code-base too Closes gh-896
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #721 and #429