Skip to content
This repository has been archived by the owner on Mar 23, 2024. It is now read-only.

Add new values and deprecate some for (require | disallow)SpacesInsideObjectBrackets #893

Closed
wants to merge 3 commits into from

Conversation

markelog
Copy link
Member

@markelog markelog commented Jan 9, 2015

See #721, although without only but with allExcept for both

Aside from main improvement:

* Simplify logic check

* Use assertion API

* Add couple more tests for main logic

Ref jscs-dev#721
Aside from main improvement:

* Simplify logic check

* Use assertion API

Closes jscs-dev#721
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) when pulling 777014d on markelog:SpacesInsideObjectBrackets into 67f6e8d on jscs-dev:master.

@markelog
Copy link
Member Author

markelog commented Jan 9, 2015

Coverage decreased (-0.04%)

Because of the configure ifs, i find it tedious to add tests for it, should be resolved with #895 instead

@@ -20,7 +26,13 @@
* ##### Valid for mode `"nested"`
*
* ```js
* var x = { a: {b: 1} };
* var x = {a: {b: 1} };
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Space missed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, it was a mistake, see description of the rule

@markelog markelog added this to the 1.10 milestone Jan 15, 2015
markelog added a commit to markelog/node-jscs that referenced this pull request Jan 15, 2015
@markelog markelog closed this in 7a6ca25 Jan 15, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants