Close #605: Disable type check for test, start, build commands in CI #606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 812156d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
LukeSheard
reviewed
Jul 14, 2021
|
Passing: Silent:
For CI:
For Non-CI |
LukeSheard
reviewed
Jul 16, 2021
LukeSheard
reviewed
Jul 16, 2021
LukeSheard
reviewed
Jul 16, 2021
LukeSheard
reviewed
Jul 16, 2021
LukeSheard
reviewed
Jul 16, 2021
LukeSheard
reviewed
Jul 16, 2021
LukeSheard
reviewed
Jul 16, 2021
packages/modular-scripts/react-scripts/config/webpack.config.js
Outdated
Show resolved
Hide resolved
LukeSheard
suggested changes
Jul 16, 2021
added 8 commits
July 16, 2021 08:57
LukeSheard
approved these changes
Jul 20, 2021
packages/modular-scripts/src/cli.ts
Outdated
|
|
||
| program | ||
| .command('typecheck') | ||
| .option( |
There was a problem hiding this comment.
What's the use case for this? I would avoid adding any unnecessary APIs to this until we've got a better idea of when we'll need them.
There was a problem hiding this comment.
I added this as a way to silence error messages and provide a green/red light on typechecking. I'm impartial so I will remove for simplicity's sake.
LukeSheard
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typechecks are run every time
start,build, andtestare run within the CI environment. If it's a CI environment, we should disable typecheck. This will improve performance of each command.Because typecheck is enabled and performed during the local development start, build, and test runs, there is no need for the CI to rerun the check with every command in the CI pipeline. Typechecking should be its own step and done only once over the project within the CI environment.
modular typecheckruns tsc over the project and should be used explicitly to typecheck the project as part of the SDLC process.Addressing #605