Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable typechecking in CI #605

Closed
cangarugula opened this issue Jul 14, 2021 · 0 comments · Fixed by #606
Closed

Disable typechecking in CI #605

cangarugula opened this issue Jul 14, 2021 · 0 comments · Fixed by #606
Assignees
Labels
enhancement New feature or request medium priority

Comments

@cangarugula
Copy link
Contributor

cangarugula commented Jul 14, 2021

Currently, typechecking happens every time start, build, or test are executed. For development, this is standard and should be enforced. But for the CI environment, there is no need to typecheck over and over again with every command in the CI pipeline because the code does not change between steps.

If it's a CI environment, it makes sense to disable typechecking for start, build, and test and make typechecking its own step and done only once over the codebase within the CI environment, preferably before wasting CPU resources to run the other steps if it encounters a failure. This will improve performance of each CI run.

Typecheck will is still be enabled and enforced during the local development, nothing should change for the everyday development experience.

a modular typecheck command should exist to run typecheck over the project as an explicit action for CI steps.

@cangarugula cangarugula added enhancement New feature or request medium priority labels Jul 14, 2021
@cangarugula cangarugula self-assigned this Jul 14, 2021
LukeSheard pushed a commit that referenced this issue Jul 21, 2021
* Silence diagnostics in CI

* update yarn lock

Co-authored-by: Cang Truong <cang.truong@chase.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request medium priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant