Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update AFDX Secret APIs #7

Merged
merged 9 commits into from
Jun 24, 2021
Merged

Update AFDX Secret APIs #7

merged 9 commits into from
Jun 24, 2021

Conversation

jessicl-ms
Copy link
Collaborator

@jessicl-ms jessicl-ms commented Jun 9, 2021 •
edited
Loading

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
    • Adding a new service

  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@jessicl-ms jessicl-ms force-pushed the jessicl/swagger-updates-secret-domain branch from fe8b5b5 to c46f241 Compare June 21, 2021 23:27
jorinmejia
jorinmejia previously approved these changes Jun 23, 2021
View reviewed changes
Copy link
Owner

@jorinmejia jorinmejia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jessicl-ms jessicl-ms merged commit 7f33725 into cdn-swagger-2021-06-01 Jun 24, 2021
jorinmejia pushed a commit that referenced this pull request Nov 23, 2021
@solankisamir @azaslonov
@yingru97 @JatinSanghvi @atharos1 @VitaliyKurokhtin @RupengLiu @msyyc
Microsoft.ApiManagement : Release api-version 2021-04-01-preview (Azu…
0208c5d 
…re#15832)

* Adds base for updating Microsoft.ApiManagement from version preview/2021-01-01-preview to version 2021-04-01-preview

* Updates readme

* Updates API version in new specs and examples

* Added support for GraphQL API type (Azure#14851)

* Added support for GraphQL API type

* Added missing enum value for GraphQL APIs.

* add schema definition fix from 2021-01-01-preview (Azure#14883)

Co-authored-by: Alan Feng <alanfeng@microsoft.com>

* Vanguard: Get Outbound Network Dependency (Azure#14900)

* outbound dependency

* fix resource

* Update backup/restore API for managed identities (Azure#14973)

* Update backup/restore API for system-assigned and user-assigned identities

* Fix formatting issue

* Rename user-assigned-msi-client-id with client-id

* SystemData implemenation on API Management Control Plane (Azure#14899)

* system-data

* fix spec

* remove unreferenced file

* APIM - Network Watcher Connectivity Check integration specs (Azure#15056)

* Connectivity Check API Specs

* Fix

* Fix errors

* style fixs

* Fix 202 code

* HTTPConnect request parameters

* Fix errors

Co-authored-by: Nicolás Barrera <t-nbarrera@microsoft.com>

* Parameter examples added (Azure#14836)

* platformversion (Azure#15114)

* fix update service (Azure#15478)

* HttpConnect example (Azure#15493)

* HttpConnect example

* Prettifier fix

Co-authored-by: Nicolás Barrera <t-nbarrera@microsoft.com>

* Added properties of difference API spec format for "SchemaDocumentProperties" (Azure#15703)

* add schema definition fix from 2021-01-01-preview

* added properties for SchemaDocumentProperties

* updated the fix

* updated fix

* [APIM]Add private endpoint connection APIs (Azure#15115)

* Add private endpoint connection apis

* add readme

* quick fixes

* fix to PE contract

* Small fixes

* small fixes

* small fixes

* Small fixes

* small fixes

* small fix

* small fixes

* small fixes

* small fixes

* Update readme.md

* fix error

* small fix

* fix format

* address comments

* small fixes

* Change to lower case

* small fixes

Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com>

* Adds base for updating Microsoft.ApiManagement from version preview/2021-01-01-preview to version 2021-04-01-preview

* Updates readme

* Updates API version in new specs and examples

* Added support for GraphQL API type (Azure#14851)

* Added support for GraphQL API type

* Added missing enum value for GraphQL APIs.

* add schema definition fix from 2021-01-01-preview (Azure#14883)

Co-authored-by: Alan Feng <alanfeng@microsoft.com>

* Vanguard: Get Outbound Network Dependency (Azure#14900)

* outbound dependency

* fix resource

* Update backup/restore API for managed identities (Azure#14973)

* Update backup/restore API for system-assigned and user-assigned identities

* Fix formatting issue

* Rename user-assigned-msi-client-id with client-id

* SystemData implemenation on API Management Control Plane (Azure#14899)

* system-data

* fix spec

* remove unreferenced file

* APIM - Network Watcher Connectivity Check integration specs (Azure#15056)

* Connectivity Check API Specs

* Fix

* Fix errors

* style fixs

* Fix 202 code

* HTTPConnect request parameters

* Fix errors

Co-authored-by: Nicolás Barrera <t-nbarrera@microsoft.com>

* Parameter examples added (Azure#14836)

* platformversion (Azure#15114)

* fix update service (Azure#15478)

* HttpConnect example (Azure#15493)

* HttpConnect example

* Prettifier fix

Co-authored-by: Nicolás Barrera <t-nbarrera@microsoft.com>

* Added properties of difference API spec format for "SchemaDocumentProperties" (Azure#15703)

* add schema definition fix from 2021-01-01-preview

* added properties for SchemaDocumentProperties

* updated the fix

* updated fix

* [APIM]Add private endpoint connection APIs (Azure#15115)

* Add private endpoint connection apis

* add readme

* quick fixes

* fix to PE contract

* Small fixes

* small fixes

* small fixes

* Small fixes

* small fixes

* small fix

* small fixes

* small fixes

* small fixes

* Update readme.md

* fix error

* small fix

* fix format

* address comments

* small fixes

* Change to lower case

* small fixes

Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com>

* fix tenant sync contract

* fix linter issues

* examples for managed identity backup

* prettier

* Fix Apis-Get and updated comments for api-version 2021-04-01-preview (#3)

* add schema definition fix from 2021-01-01-preview

* added fix

* small fix (#6)

* 'examples' added to RepresentationContract (#7)

Co-authored-by: Alexander Zaslonov <zaslonov.alexander@gmail.com>
Co-authored-by: DreamlessA <DreamlessA@users.noreply.github.com>
Co-authored-by: Alan Feng <alanfeng@microsoft.com>
Co-authored-by: Jatin Sanghvi <20547963+JatinSanghvi@users.noreply.github.com>
Co-authored-by: Nicolás Barrera <nicolasbarrera@outlook.com>
Co-authored-by: Nicolás Barrera <t-nbarrera@microsoft.com>
Co-authored-by: VitaliyKurokhtin <vitaliik@microsoft.com>
Co-authored-by: RupengLiu <rliu1211@terpmail.umd.edu>
Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com>
Co-authored-by: RupengLiu <rupliu@microsoft.com>
Co-authored-by: VitaliyKurokhtin <Vitaliy.Kurokhtin@gmail.com>
jorinmejia pushed a commit that referenced this pull request Nov 23, 2021
@niteshvijay1995 @anujtoshniwal
@abhijitkaranjkar89 @kavskalyan @vivek-microsoft @vivek67 @ajparule @amisi01 @pjohari-ms
[Hub Generated] Review request for Microsoft.DocumentDB to add versio…
5405df1 
…n preview/2021-10-15-preview (Azure#16211)

* Adds base for updating Microsoft.DocumentDB from version preview/2021-07-01-preview to version 2021-10-15-preview

* Updates readme

* Updates API version in new specs and examples

* Antoshni cosmos db 2021 10 15 preview cek management (#1)

* Adds base for updating Microsoft.DocumentDB from version preview/2021-07-01-preview to version 2021-10-15-preview

* Updates readme

* Updates API version in new specs and examples

* ClientEncryptionKey management API changes

* Address semantics validation errors

* Fix representation of wrappedDek

* fix Swagger prettier formatting check

* minor edits to address comments"

* fix LintDiff error

* Adds base for updating Microsoft.DocumentDB from version preview/2021-07-01-preview to version 2021-10-15-preview

* Updates readme

* Updates API version in new specs and examples

* remove CreateUpdateOptions as they arent applicable for CEK

* fix Model validation check

Co-authored-by: anujtoshniwal <62551957+anujtoshniwal@users.noreply.github.com>
Co-authored-by: Anuj Toshniwal <antoshni@microsoft.com>

* mongo rbac cherry-pick (#5)

* mongo rbac cherry-pick

* Removing entry for 07 preview

Co-authored-by: kavskalyan <kakhandr@microsoft.com>

* Revert "mongo rbac cherry-pick (#5)" (#7)

This reverts commit 8392017.

* preview swagger for managed cassandra (#8)

* preview swagger for managed cassandra

* add cassandraAuditLoggingEnabled property

* change property name in CommandPostBody

Co-authored-by: Vivek Sundararajan <s.vivek.rajan@gmail.com>

* fix validation, remove connectivity (#11)

Co-authored-by: Vivek Sundararajan <s.vivek.rajan@gmail.com>

* Add data transfer job api (#2)

* Adds base for updating Microsoft.DocumentDB from version preview/2021-07-01-preview to version 2021-10-15-preview

* Updates readme

* Updates API version in new specs and examples

* Add DataTransfer job apis

* Fix api version

* Rename connection to endpointUrl

* Rename connection to endpointUrl

* Add dataTransferService in readme.md

* Fix keys

* Fix checks

* Add worker count

* Fix worker count

* MaterializedViewsBuilder (#12)

* Adding LatestRestorableTimestamp support for MongoDB collections. (#9)

* Adding LatestRestorableTimestamp support for MongoDB

* Fixing api version for examples.

* Mongo RBAC Swagger Changes (#10)

* mongo rbac cherry-pick

* Removing entry for 07 preview

* Fixing swagger issues

* Fixing swagger error for param

* Fixing misplaced Description

* Fixing model validation issues

* Json pretty formatting

* Fixing more model validation issues

* Fixing type issue

* Add password field for userdef request

* Fixing URL param

* Fixing URL param issue

Co-authored-by: kavskalyan <kakhandr@microsoft.com>

* TotalThroughput limit 10-15 preview API changes (#6)

* add backupStorageCustomerKeyUri and fix response status code (#13)

* fix validation, remove connectivity

* add backupStorageCustomerKeyUri property

* fix response status code

Co-authored-by: Vivek Sundararajan <s.vivek.rajan@gmail.com>

* Prettier fix

* Fix Avocado check

* Fix operationId

* Fix operationId

* Fix breaking change

* Fix breaking change (managedCassandra invokeCommand)

* Fix breaking change

* Fix status code in example

* Fix review comment

* Use v3 version for resource-management

* Fix client encryption review comments

* update location header in example (#15)

Co-authored-by: Vivek Sundararajan <s.vivek.rajan@gmail.com>

* Prettier fix

* update header in response

* formating json

Co-authored-by: anujtoshniwal <62551957+anujtoshniwal@users.noreply.github.com>
Co-authored-by: Anuj Toshniwal <antoshni@microsoft.com>
Co-authored-by: Abhijit Karanjkar <abhijitkaranjkar@gmail.com>
Co-authored-by: kavskalyan <kakhandr@microsoft.com>
Co-authored-by: vivek-microsoft <32766101+vivek-microsoft@users.noreply.github.com>
Co-authored-by: Vivek Sundararajan <s.vivek.rajan@gmail.com>
Co-authored-by: Ajay Parulekar <79739098+ajparule@users.noreply.github.com>
Co-authored-by: Amit Singh <31076927+amisi01@users.noreply.github.com>
Co-authored-by: pjohari-ms <84465928+pjohari-ms@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rrahulms rrahulms rrahulms left review comments

@jorinmejia jorinmejia jorinmejia approved these changes

@yunheMsft yunheMsft Awaiting requested review from yunheMsft yunheMsft is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jessicl-ms @jorinmejia @rrahulms