Update odatatype #10
Merged
Update odatatype #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChenglongLiu
requested review from
jessicl-ms,
jorinmejia and
yunheMsft
as code owners
added 2 commits
July 9, 2021 11:19
jorinmejia
requested changes
Jul 13, 2021
| @@ -40,7 +40,7 @@ | |||
| "192.168.1.0/24", | |||
| "10.0.0.0/24" | |||
| ], | |||
| "@odata.type": "#Microsoft.Azure.Cdn.Models.DeliveryRuleRemoteAddressConditionParameters" | |||
| "typename": "DeliveryRuleRemoteAddressConditionParameters" | |||
There was a problem hiding this comment.
Per the email discussion, we agreed to utilize camel casing for type name. Please utilize typeName instead and change for subsequent fields.
jorinmejia
approved these changes
Jul 13, 2021
jorinmejia
pushed a commit
that referenced
this pull request
Nov 23, 2021
…n preview/2021-10-15-preview (Azure#16211) * Adds base for updating Microsoft.DocumentDB from version preview/2021-07-01-preview to version 2021-10-15-preview * Updates readme * Updates API version in new specs and examples * Antoshni cosmos db 2021 10 15 preview cek management (#1) * Adds base for updating Microsoft.DocumentDB from version preview/2021-07-01-preview to version 2021-10-15-preview * Updates readme * Updates API version in new specs and examples * ClientEncryptionKey management API changes * Address semantics validation errors * Fix representation of wrappedDek * fix Swagger prettier formatting check * minor edits to address comments" * fix LintDiff error * Adds base for updating Microsoft.DocumentDB from version preview/2021-07-01-preview to version 2021-10-15-preview * Updates readme * Updates API version in new specs and examples * remove CreateUpdateOptions as they arent applicable for CEK * fix Model validation check Co-authored-by: anujtoshniwal <62551957+anujtoshniwal@users.noreply.github.com> Co-authored-by: Anuj Toshniwal <antoshni@microsoft.com> * mongo rbac cherry-pick (#5) * mongo rbac cherry-pick * Removing entry for 07 preview Co-authored-by: kavskalyan <kakhandr@microsoft.com> * Revert "mongo rbac cherry-pick (#5)" (#7) This reverts commit 8392017. * preview swagger for managed cassandra (#8) * preview swagger for managed cassandra * add cassandraAuditLoggingEnabled property * change property name in CommandPostBody Co-authored-by: Vivek Sundararajan <s.vivek.rajan@gmail.com> * fix validation, remove connectivity (#11) Co-authored-by: Vivek Sundararajan <s.vivek.rajan@gmail.com> * Add data transfer job api (#2) * Adds base for updating Microsoft.DocumentDB from version preview/2021-07-01-preview to version 2021-10-15-preview * Updates readme * Updates API version in new specs and examples * Add DataTransfer job apis * Fix api version * Rename connection to endpointUrl * Rename connection to endpointUrl * Add dataTransferService in readme.md * Fix keys * Fix checks * Add worker count * Fix worker count * MaterializedViewsBuilder (#12) * Adding LatestRestorableTimestamp support for MongoDB collections. (#9) * Adding LatestRestorableTimestamp support for MongoDB * Fixing api version for examples. * Mongo RBAC Swagger Changes (#10) * mongo rbac cherry-pick * Removing entry for 07 preview * Fixing swagger issues * Fixing swagger error for param * Fixing misplaced Description * Fixing model validation issues * Json pretty formatting * Fixing more model validation issues * Fixing type issue * Add password field for userdef request * Fixing URL param * Fixing URL param issue Co-authored-by: kavskalyan <kakhandr@microsoft.com> * TotalThroughput limit 10-15 preview API changes (#6) * add backupStorageCustomerKeyUri and fix response status code (#13) * fix validation, remove connectivity * add backupStorageCustomerKeyUri property * fix response status code Co-authored-by: Vivek Sundararajan <s.vivek.rajan@gmail.com> * Prettier fix * Fix Avocado check * Fix operationId * Fix operationId * Fix breaking change * Fix breaking change (managedCassandra invokeCommand) * Fix breaking change * Fix status code in example * Fix review comment * Use v3 version for resource-management * Fix client encryption review comments * update location header in example (#15) Co-authored-by: Vivek Sundararajan <s.vivek.rajan@gmail.com> * Prettier fix * update header in response * formating json Co-authored-by: anujtoshniwal <62551957+anujtoshniwal@users.noreply.github.com> Co-authored-by: Anuj Toshniwal <antoshni@microsoft.com> Co-authored-by: Abhijit Karanjkar <abhijitkaranjkar@gmail.com> Co-authored-by: kavskalyan <kakhandr@microsoft.com> Co-authored-by: vivek-microsoft <32766101+vivek-microsoft@users.noreply.github.com> Co-authored-by: Vivek Sundararajan <s.vivek.rajan@gmail.com> Co-authored-by: Ajay Parulekar <79739098+ajparule@users.noreply.github.com> Co-authored-by: Amit Singh <31076927+amisi01@users.noreply.github.com> Co-authored-by: pjohari-ms <84465928+pjohari-ms@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.