httpURLConnection.getErrorStream() can return null so handle it. #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @brycechesternewman, thank you for your PR. For me it's ok, but before merge it, can you write a test to verify the problem? I'm not sure if is possible, but if you can, it would be very appreciated |
brycechesternewman
force-pushed
the
issue-30
branch
from
d65c09e
to
497b786
Compare
|
@henryx howdy. Can you have another look please? |
brycechesternewman
force-pushed
the
issue-30
branch
from
9f22538
to
cb2d092
Compare
CI fails because it lacks the newline in file. This commit adds it
|
@henryx Thank you for merging. What is your typical release schedule? I want to make use of this asap. Thanks again. |
|
I've released new version with this patch. For some reasons, publishing to Maven Central is a bit slow. If you need asap this release, you can use jitpack.io as as alternate package repository |
|
I am not yet seeing 4.5.0 published to maven central https://repo1.maven.org/maven2/io/github/jopenlibs/vault-java-driver/. Perhaps it is not replicated yet? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30