httpURLConnection.getErrorStream() can return null so handle it. (#31)

Co-authored-by: Enrico Bianchi <enrico.bianchi@gmail.com>
jopenlibs · Apr 25, 2023 · cd25b49 · cd25b49
1 parent 72eba45
commit cd25b49
Show file tree

Hide file tree

Showing 2 changed files with 39 additions and 8 deletions.
diff --git a/src/main/java/io/github/jopenlibs/vault/rest/Rest.java b/src/main/java/io/github/jopenlibs/vault/rest/Rest.java
@@ -545,14 +545,7 @@ private byte[] responseBodyBytes(final URLConnection connection) throws RestExce
                     inputStream = httpURLConnection.getErrorStream();
                 }
             }
-            final ByteArrayOutputStream byteArrayOutputStream = new ByteArrayOutputStream();
-            int bytesRead;
-            final byte[] bytes = new byte[16384];
-            while ((bytesRead = inputStream.read(bytes, 0, bytes.length)) != -1) {
-                byteArrayOutputStream.write(bytes, 0, bytesRead);
-            }
-            byteArrayOutputStream.flush();
-            return byteArrayOutputStream.toByteArray();
+            return handleResponseInputStream(inputStream);
         } catch (IOException e) {
             return new byte[0];
         }
@@ -586,4 +579,31 @@ private int connectionStatus(final URLConnection connection) throws IOException,
         return statusCode;
     }
 
+    /**
+     * <p>This method handles the response stream from the connection.</p>
+     *
+     * @param inputStream The input stream from the connection.
+     * @return The body payload, downloaded from the HTTP connection response
+     */
+    protected byte[] handleResponseInputStream(final InputStream inputStream) {
+        try {
+            // getErrorStream() can return null so handle it.
+            if (inputStream != null) {
+                final ByteArrayOutputStream byteArrayOutputStream = new ByteArrayOutputStream();
+
+                int bytesRead;
+                final byte[] bytes = new byte[16384];
+                while ((bytesRead = inputStream.read(bytes, 0, bytes.length)) != -1) {
+                    byteArrayOutputStream.write(bytes, 0, bytesRead);
+                }
+
+                byteArrayOutputStream.flush();
+                return byteArrayOutputStream.toByteArray();
+            } else {
+                return new byte[0];
+            }
+        } catch (IOException e) {
+            return new byte[0];
+        }
+    }
 }
diff --git a/src/test/java/io/github/jopenlibs/vault/rest/GetTests.java b/src/test/java/io/github/jopenlibs/vault/rest/GetTests.java
@@ -192,4 +192,15 @@ public void testGet_RetrievesResponseBodyWhenStatusIs418() throws RestException
                 responseBody.contains("User-Agent"));
     }
 
+
+    /**
+     * <p>Verify that response body does not cause NPE when input stream is null.</p>
+     */
+    @Test
+    public void test_handleResponseInputStream() {
+        final Rest rest = new Rest();
+        final byte[] result = rest.handleResponseInputStream(null);
+        assertEquals(0, result.length);
+    }
+
 }