fix(storage): internals list function not able to decide which output… #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… types to use (#13915) chore: add function overloading to list
joon-won
merged commit 0c2b46b
into
joon-won:sb/integrity/expected-bucket-owner
1 check passed
joon-won
pushed a commit
that referenced
this pull request
Nov 26, 2024
* chore: disable dependency review * feat(auth): associateWebAuthnCredential API (#1) * feat(auth): signIn with a webauthn credential (#3) wip * feat(auth): listWebAuthnCredentials API (#6) * feat(auth): deleteWebAuthnCredential API (aws-amplify#8) * feat(auth): Added signInWithUserAuth for password-less Sign-In (#2) * feat(auth): Add USER_AUTH flow in Sign Up logic (aws-amplify#11) * feat(auth): enable autoSignIn support for passwordless (aws-amplify#7) * tmp disable code ql * handle SMS_OTP sign in result * cache session from signup and confirmsignup both * add getSignInResult test * bundle size tests * feat(passwordless): refactor to support new Cognito API changes (aws-amplify#14) * refactor to support new APIs * bundle size updates * update exception mapping (aws-amplify#15) * feat(auth): passwordless webauthn ceremony errors (aws-amplify#16) * update exception mapping * update passkey error handling * update tests * bundle size tests * simplify language * refine error messages * fix(auth): clear auto sign in store on sign in (aws-amplify#18) * fix(auth): clear auto sign in store on sign in * add unit test * feat(auth): refactor foundational APIs to not access singleton (aws-amplify#17) * enable ssr list and delete web authn credentials * update unit tests * add foundation tests * revert: expose server APIs * feat(auth): passwordless - enable test specs / push trigger (aws-amplify#19) * enable test specs / push trigger * check for PublicKeyCredential * bundle size tests * fix recovery suggestion language * align assertion with expected type * fix tsdocs * bundle size updates * fix(auth): passwordless pr feedback (aws-amplify#22) * callout in ts docs for password requirement * unify callback and store reset for autosignin * comment for clarity * enable integ tests * fix: set active username after auth attempt to maintain consistent user context * temporarily run single test spec per environment * reset push integ yml --------- Co-authored-by: Parker Scanlon <69879391+scanlonp@users.noreply.github.com> Co-authored-by: yuhengshs <yuhengsh@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… types to use (aws-amplify#13915)
chore: add function overloading to list
Description of changes
Issue #, if available
Description of how you validated changes
Checklist
yarn testpassesChecklist for repo maintainers
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.