Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

propTypes warnings on sign in and sign up pages #8

Closed
oluckyman opened this issue Nov 20, 2017 · 5 comments
Closed

propTypes warnings on sign in and sign up pages #8

oluckyman opened this issue Nov 20, 2017 · 5 comments

Comments

@oluckyman
Copy link

When wrapping App inside Authenticator component:

export default props => (
  <Authenticator
    amplifyConfig={amplifyConfig}
  >
    <App {...props} />
  </Authenticator>
);

I am getting that warning on sign in page:
image

This on on sign up page:
image

@richardzcode
Copy link
Contributor

Hey @oluckyman in our local env we don't see the warning. I'm guessing it is the way we remove prop behaves differently in different dev setup. I've made a patch to remove the props properly. Could you get the latest library to have a try?

Thanks,
Richard

@oluckyman
Copy link
Author

Tried the latest version (aws-amplify-react@0.1.4) and it was not work at all:
image

Then updated aws-amplify@0.1.3 as well. It works, but there is a warning again this time on <a> node:
image

@richardzcode
Copy link
Contributor

Yes it requires aws-amplify@0.1.3. The second one was missed. Now fixed.

Thanks,
Richard

@oluckyman
Copy link
Author

Thanks 👍

@github-actions
Copy link

This issue has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants