Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix domain checking for request #40080

Merged
merged 3 commits into from
Mar 12, 2023
Merged

Fix domain checking for request #40080

merged 3 commits into from
Mar 12, 2023

Conversation

Fedik
Copy link
Member

@Fedik Fedik commented Mar 11, 2023

Pull Request for Issue #39969 and #39970 and #39580.

Alternative to PR #39970 .

Summary of Changes

Better checking for domain

Testing Instructions

Apply patch, run npm install
Please follow #39969

Actual result BEFORE applying this Pull Request

Installation broken

Expected result AFTER applying this Pull Request

Installation works

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.3-dev labels Mar 11, 2023
@richard67
Copy link
Member

@Fedik Is this an alternative for PR #39970 ? Or is it an addition to it?

@Fedik
Copy link
Member Author

Fedik commented Mar 12, 2023

This is alternative

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on a632e7e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40080.

@joomdonation
Copy link
Contributor

So I tested it and it solved the issue. Sending test mail from Global Configuration is still working, too

However, there is one case which I think the test does not pass. Assume the current site is http://localhost/joomla42, if ajax request make to http://localhost/joomla43, the token is still send. It's not a big thing, I guess, so if you confirm that it is OK, I will report my test result @Fedik

@obuisard
Copy link
Contributor

Tuan @joomdonation can you confirm the test is ok and report in the issue tracker? Thank you!

@joomdonation
Copy link
Contributor

I have tested this item ✅ successfully on a632e7e

Not 100% accurate but should be OK.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40080.

@joomdonation
Copy link
Contributor

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40080.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 12, 2023
@obuisard obuisard added this to the Joomla! 4.3.0 milestone Mar 12, 2023
@obuisard obuisard merged commit 01f1a9f into joomla:4.3-dev Mar 12, 2023
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 12, 2023
@obuisard
Copy link
Contributor

Thank you Fedir @Fedik for the PR!

@Fedik Fedik deleted the fix39969 branch March 12, 2023 13:58
@Fedik
Copy link
Member Author

Fedik commented Mar 12, 2023

Assume the current site is http://localhost/joomla42, if ajax request make to http://localhost/joomla43, the token is still send

As long as you an owner of the domain, that should be fine :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPM Resource Changed This Pull Request can't be tested by Patchtester
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants