Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.3] Error installing extensions - Release blocker? #39969

Closed
brianteeman opened this issue Feb 28, 2023 · 6 comments
Closed

[4.3] Error installing extensions - Release blocker? #39969

brianteeman opened this issue Feb 28, 2023 · 6 comments

Comments

@brianteeman
Copy link
Contributor

Steps to reproduce the issue

Try to upload an install any extension
Try to drag and drop to install an extension

Expected result

No errors and both methods are successful at installing an extension

Actual result

Upload works
drag and drop does not
image

Unexpected token 'T', "The most r"... is not valid JSON

chrome_2023-02-28_16-39-24.mp4
@MacJoom
Copy link
Contributor

MacJoom commented Feb 28, 2023

Confirmed. Other Json Error
JSON.parse: unexpected character at line 1 column 1 of the JSON data
Screenshot 2023-02-28 at 18-21-22 Extensions Install - Bugtest - Administration

@wilsonge
Copy link
Contributor

csrf token doesn't match. Assuming #39580 isn't handling the relative url stuff

@wilsonge
Copy link
Contributor

Patch #39970 but I suspect reverting the original pr might be a better fix??

@brianteeman
Copy link
Contributor Author

brianteeman commented Feb 28, 2023

#39970 didnt fix anything :(

@brianteeman
Copy link
Contributor Author

Sorry - applied pr on a different server to the one I tested.

Can confirm it is caused by #39580 and the patch works as well.

@Hackwar Hackwar added the bug label Mar 1, 2023
@alikon
Copy link
Contributor

alikon commented Mar 3, 2023

let's swittch the discussion on the pr #39970

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants