This repository was archived by the owner on Feb 8, 2025. It is now read-only.
migrate to rand 0.9.0
#12
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This migrates the usage of `rand` to what it expects in the new version. Before this, it was not possible to use this crate alongside a newer rand version. After this, this crate will probably not be backward compatible with earlier rand versions
|
+1 please merge this so we can use the latest rand |
|
cc @jonhoo |
No longer needed, migrated to rand_distr |
|
@rkuris Interesting. Could you share the PR for migration? I may follow your solution :P |
|
See ava-labs/firewood#775
This other zipf library in rand_distr only works with floats but there is a
comment in the docs that you can cast it to integers if needed, so we did
that and it seems to work fine.
…On Mon, Feb 3, 2025, 4:42 PM tison ***@***.***> wrote:
@rkuris <https://github.com/rkuris> Interesting. Could you share the PR
for migration? I may follow your solution :P
—
Reply to this email directly, view it on GitHub
<#12 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAYLR3BTJ5GWMAOL5B3P5TL2OAEH7AVCNFSM6AAAAABWBJ4XCSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMZSGUYDEMBUGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Thanks. I tried it at foyer-rs/foyer#854. |
|
Sorry for the delay! Now that there is Zipf support directly in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This migrates the usage of
randto what it expects in the new version, so that it implements the right traits that have been changed. Here is the migration guide.Before this, it was not possible to use this crate alongside a newer rand version. After this, this crate will probably not be backward compatible with earlier rand versions