Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(deps): adopt rand 0.9 #854

Merged
merged 1 commit into from
Feb 4, 2025
Merged

refactor(deps): adopt rand 0.9 #854

merged 1 commit into from
Feb 4, 2025

Conversation

tisonkun
Copy link
Contributor

@tisonkun tisonkun commented Feb 4, 2025

AS IS

let mut keys = Vec::with_capacity(ITERATIONS);
for _ in 0..ITERATIONS {
let key = zipf.sample(&mut rng).to_string();
let key = zipf.sample(&mut rng).round() as usize;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: tison <wander4096@gmail.com>
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 77.27273% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
foyer-bench/src/main.rs 66.66% 3 Missing ⚠️
foyer-storage/src/storage/either.rs 0.00% 2 Missing ⚠️
Files with missing lines Coverage Δ
foyer-common/src/asyncify.rs 100.00% <ø> (+50.00%) ⬆️
foyer-common/src/rate.rs 98.18% <100.00%> (ø)
foyer-common/src/rated_ticket.rs 100.00% <100.00%> (ø)
foyer-common/src/runtime.rs 78.04% <ø> (ø)
foyer-memory/src/cache.rs 78.76% <100.00%> (ø)
foyer-memory/src/raw.rs 88.96% <ø> (ø)
foyer-storage/src/region.rs 94.25% <100.00%> (+3.09%) ⬆️
foyer-storage/src/store.rs 86.69% <100.00%> (+0.06%) ⬆️
foyer-storage/src/storage/either.rs 40.81% <0.00%> (ø)
foyer-bench/src/main.rs 64.85% <66.66%> (+0.01%) ⬆️

... and 3 files with indirect coverage changes

Copy link
Collaborator

@MrCroxx MrCroxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank you for your contribution. 🥰

I found there are some other reactors in this PR such as removing unused APIs and refactors on madsim usage. Please try to open a separate PR for that next time, or briefly mention it in the PR message. But it is totally up to you. 🙌

Thank you again for your efforts.

Thank you again for

@MrCroxx MrCroxx added dependencies Pull requests that update a dependency file refactor labels Feb 4, 2025
@MrCroxx MrCroxx added this to the v0.14 milestone Feb 4, 2025
@MrCroxx MrCroxx changed the title build: adopt rand 0.9 deps: adopt rand 0.9 Feb 4, 2025
@MrCroxx MrCroxx changed the title deps: adopt rand 0.9 refactor(deps): adopt rand 0.9 Feb 4, 2025
@MrCroxx MrCroxx merged commit ca3293f into foyer-rs:main Feb 4, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file refactor
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants